-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTMDB-198: Fixes a bug where it appears empty private endpoint in cluster #481
Conversation
@threebee I added you since the APIx group added Andrea who is OOO. Hope this is okay! If not feel free to reassign. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@coderGo93 I talked with Chris who works with private link quite a bit and he feels Azure should be given the same amount of time. Can we do this for both providers? |
Hi @themantissa , just updated validation so it can be refreshed if the provider is azure or aws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the add.
Description
AWS
orAZURE
with 10 minutes as timeout in datasource of cluster.This was tested manually because in issue, was using an existing cluster with datasource.
The example is the same in folder
/examples/aws-atlas-privatelink
with small modifications in fileatlas-cluster.tf
like thisThe results are OK after waiting for
data.mongodbatlas_cluster.cluster-atlas
, it took between 3-5 minLink to any related issue(s):
#422
Type of change:
Required Checklist:
Further comments