Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-90710: Expose BASE_URL so that we can test terraform with a custom server #467

Merged
merged 6 commits into from
May 26, 2021
Merged

CLOUDP-90710: Expose BASE_URL so that we can test terraform with a custom server #467

merged 6 commits into from
May 26, 2021

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented May 26, 2021 •
edited
Loading

Description

I have exposed the property MONGODB_ATLAS_BASE_URL so that we can test terraform with a custom server.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo marked this pull request as ready for review May 26, 2021 13:42
@andreaangiolillo andreaangiolillo requested a review from gssbzn May 26, 2021 13:42
gssbzn
gssbzn approved these changes May 26, 2021
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this will make us using this internally way easier for our own testing

@andreaangiolillo andreaangiolillo changed the title Added MONGODB_ATLAS_BASE_URL property CLOUDP-90710: Expose BASE_URL so that we can test terraform with a custom server May 26, 2021
leofigy
leofigy approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@leofigy leofigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

themantissa
themantissa approved these changes May 26, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, not just for cloud-dev but if we get to my dreamed of state of having the ability to do mock servers :) Thank you!

@andreaangiolillo andreaangiolillo merged commit b58b0fe into master May 26, 2021
@themantissa themantissa deleted the add_base_url_prop branch August 10, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofigy leofigy leofigy approved these changes

@themantissa themantissa themantissa approved these changes

@gssbzn gssbzn gssbzn approved these changes

@coderGo93 coderGo93 Awaiting requested review from coderGo93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreaangiolillo @gssbzn @themantissa @leofigy