Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-208: Updated docs for upgrading private endpoints #458

Merged
merged 8 commits into from
May 13, 2021

Conversation

coderGo93
Copy link
Contributor

Description

  • Added terratest for upgrading with resources mongodbatlas_private_endpoint and mongodbatlas_private_endpoint_interface_link
  • Updated docs for guide upgrading v0.9.1
  • Added validation where it should run make testacc if there's changes for folder mongodbatlas/ and should not run for changes inside folder website/docs

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@coderGo93 coderGo93 requested a review from leofigy May 12, 2021 17:56
@coderGo93 coderGo93 self-assigned this May 12, 2021
@coderGo93 coderGo93 requested a review from themantissa as a code owner May 12, 2021 17:56
@coderGo93 coderGo93 added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels May 12, 2021
@coderGo93 coderGo93 added the run-testacc To run acceptance tests label May 12, 2021
@coderGo93 coderGo93 added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels May 12, 2021
$ terraform state rm mongodbatlas_private_endpoint_interface_link.test
```

2. Change the version of provider to the newest version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's say the version 0.9.1 , because in theory for v1 because is a major version old deprecated resources should be removed finally

Copy link
Contributor

@leofigy leofigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small improvement to link to the new resources, otherwise LGTM.

configuration and real physical resources that exist. As a result, no
actions need to be performed.

Warning: this resource is deprecated, please transition as soon as possible to mongodbatlas_privatelink_endpoint
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a docs link to mongodbatlas_privatelink_endpoint on the phrase "mongodbatlas_privatelink_endpoint"




Warning: this resource is deprecated, please transition as soon as possible to mongodbatlas_privatelink_endpoint_service
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a docs link to mongodbatlas_privatelink_endpoint_service on the phrase "mongodbatlas_privatelink_endpoint_service"

@coderGo93 coderGo93 requested a review from themantissa May 12, 2021 22:20
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coderGo93 coderGo93 merged commit ace607f into master May 13, 2021
@coderGo93 coderGo93 deleted the INTMDB-208 branch May 13, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-testacc To run acceptance tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants