Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IOPS and adjust parameter description #443

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Remove IOPS and adjust parameter description #443

merged 1 commit into from
Apr 22, 2021

Conversation

themantissa
Copy link
Collaborator

@themantissa themantissa commented Apr 22, 2021 •
edited
Loading

Description

Remove IOPS in examples as it's not needed and creating confusion. Also adjust parameter description to better express current state.

Link to any related issue(s): #439

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • [ X] I have signed the MongoDB CLA
  • [ X] I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@themantissa
Remove IOPS and adjust parameter description
21c8200 
Remove IOPS in examples as it's not needed and creating confusion. Also adjust parameter description to better express current state.
leofigy
leofigy approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@leofigy leofigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shum
shum approved these changes Apr 22, 2021
View reviewed changes
Copy link
Collaborator

@shum shum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themantissa themantissa merged commit 3036569 into master Apr 22, 2021
@themantissa themantissa deleted the remove-iops-and-update branch August 10, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofigy leofigy leofigy approved these changes

@shum shum shum approved these changes

@coderGo93 coderGo93 Awaiting requested review from coderGo93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@themantissa @shum @leofigy