Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-194: Added func to get db major version for testing #427

Merged
merged 2 commits into from
Apr 6, 2021
Merged

INTMDB-194: Added func to get db major version for testing #427

merged 2 commits into from
Apr 6, 2021

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Mar 29, 2021 •
edited
Loading

Description

  • Added a func to get db major version and use it to pass to config via parameter for testing so it
  • Tests passed for TestAccResourceMongoDBAtlasCluster_tenant and TestAccResourceMongoDBAtlasCluster_tenant_m5

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Fixes #419

@coderGo93 coderGo93 self-assigned this Mar 29, 2021
@coderGo93 coderGo93 changed the title INTMDB-194: Added func to get db major version INTMDB-194: Added func to get db major version in test Mar 29, 2021
@coderGo93 coderGo93 changed the title INTMDB-194: Added func to get db major version in test INTMDB-194: Added func to get db major version for testing Mar 29, 2021
themantissa
themantissa approved these changes Mar 29, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@coderGo93 coderGo93 requested a review from pitakill March 30, 2021 01:25
themantissa
themantissa approved these changes Apr 2, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

leofigy
leofigy approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@leofigy leofigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really straightforward :) thanks !

@coderGo93 coderGo93 added the run-testacc To run acceptance tests label Apr 6, 2021
@coderGo93 coderGo93 added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Apr 6, 2021
@coderGo93 coderGo93 merged commit 0bb6c63 into master Apr 6, 2021
@coderGo93 coderGo93 deleted the INTMDB-194 branch April 6, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofigy leofigy leofigy approved these changes

@themantissa themantissa themantissa approved these changes

@pitakill pitakill Awaiting requested review from pitakill

Assignees

@coderGo93 coderGo93

Labels
run-testacc To run acceptance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tenant Provider Acceptance tests are failing
3 participants
@coderGo93 @themantissa @leofigy