Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-19: Added resource and datasource(s) of data lake #414

Merged
merged 18 commits into from
Jun 12, 2021
Merged

INTMDB-19: Added resource and datasource(s) of data lake #414

merged 18 commits into from
Jun 12, 2021

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Feb 15, 2021 •
edited
Loading

Description

Added resource and datasource(s) of data lake
Tests:

  • TestAccResourceMongoDBAtlasDataLake_basic
  • TestAccDataSourceMongoDBAtlasDataLake_basic
  • TestAccDataSourceMongoDBAtlasDataLakes_basic
  • TestTerraformResourceMongoDBAtlasEncryptionAtRestWithRole_basicAWS (Terratest)

Fixes:

  • Bug where it's wrong type in schema for cloud provider access, for field feature_id inside of object feature_usages

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Deprecated Project whitelist to avoid error related to client, will create another PR with the docs related to project list deprecation

@coderGo93 coderGo93 self-assigned this Feb 15, 2021
@leofigy leofigy added the V1 label Apr 5, 2021
@MihaiBojin
Copy link
Contributor

FYI @leofigy there's a merge conflict.

1 similar comment
@MihaiBojin
Copy link
Contributor

FYI @leofigy there's a merge conflict.

@themantissa
Copy link
Collaborator

@MihaiBojin The work was done a bit out of order due to where I had the ranking of tickets for versions. I've sorted that out but work proceeded on the current version so this is now based off an older branch of master. This will go in the next provider version. So likely best to resolve the conflicts after 0.9.0 is out.

themantissa
themantissa requested changes May 26, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small changes and questions - also need Angel's question addressed. We should also review the API doc to make sure nothing changed since this was started (though the tests should catch anything major).

examples/atlas-dataLake-roles/aws-roles.tf Outdated Show resolved Hide resolved
examples/atlas-dataLake-roles/versions.tf Outdated Show resolved Hide resolved
mongodbatlas/data_source_mongodbatlas_data_lakes.go Show resolved Hide resolved
mongodbatlas/resource_mongodbatlas_data_lake.go Outdated Show resolved Hide resolved
mongodbatlas/resource_mongodbatlas_data_lake.go Outdated Show resolved Hide resolved
mongodbatlas/resource_mongodbatlas_data_lake_test.go Outdated Show resolved Hide resolved
website/docs/r/data_lake.html.markdown Outdated Show resolved Hide resolved
@coderGo93 coderGo93 requested review from themantissa and leofigy May 26, 2021 23:31
@leofigy leofigy requested a review from andreaangiolillo May 28, 2021 02:05
andreaangiolillo
andreaangiolillo reviewed May 31, 2021
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! I have some questions and nits : )

examples/atlas-dataLake-roles/import/provider.tf Show resolved Hide resolved
examples/atlas-dataLake-roles/import/variables.tf Show resolved Hide resolved
examples/atlas-dataLake-roles/main.tf Show resolved Hide resolved
integration-testing/resource_mongodbatlas_data_lake_test.go Outdated Show resolved Hide resolved
integration-testing/resource_mongodbatlas_data_lake_test.go Show resolved Hide resolved
mongodbatlas/data_source_mongodbatlas_data_lake_test.go Outdated Show resolved Hide resolved
mongodbatlas/data_source_mongodbatlas_data_lakes.go Outdated Show resolved Hide resolved
mongodbatlas/resource_mongodbatlas_data_lake.go Show resolved Hide resolved
mongodbatlas/resource_mongodbatlas_data_lake.go Show resolved Hide resolved
mongodbatlas/resource_mongodbatlas_data_lake.go Show resolved Hide resolved
andreaangiolillo
andreaangiolillo reviewed Jun 3, 2021
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments haven’t been addressed yet

@themantissa
Copy link
Collaborator

@coderGo93 as Andrea (@andreaangiolillo) noted his comments have not been addressed so not sure why the request for another review? @leofigy perhaps you can help as well here.

@coderGo93 coderGo93 requested a review from abner-dou as a code owner June 9, 2021 02:22
@coderGo93
Copy link
Contributor Author

Hi @themantissa , sure I have answered questions of andrea , and I pulled the master with the changes of whitelist deprecated in order to work because of client mongodb atlas, let me know if you have more questions, @andreaangiolillo

themantissa
themantissa approved these changes Jun 10, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you. @andreaangiolillo I think just needs a re-review from you :)

andreaangiolillo
andreaangiolillo approved these changes Jun 11, 2021
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for addressing all my comments! : )

abner-dou
abner-dou approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@abner-dou abner-dou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coderGo93 coderGo93 added the run-testacc To run acceptance tests label Jun 11, 2021
@coderGo93 coderGo93 added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Jun 11, 2021
@coderGo93 coderGo93 added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Jun 11, 2021
@coderGo93 coderGo93 merged commit 3581244 into master Jun 12, 2021
@coderGo93 coderGo93 deleted the INTMDB-19 branch June 12, 2021 01:46
@themantissa themantissa mentioned this pull request Jun 28, 2021
Closed
@themantissa themantissa linked an issue Jun 28, 2021 that may be closed by this pull request
Cloud Provider Access Setup for Datalake #486
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abner-dou abner-dou abner-dou approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@themantissa themantissa themantissa approved these changes

@leofigy leofigy Awaiting requested review from leofigy

Assignees

@coderGo93 coderGo93

Labels
run-testacc To run acceptance tests V1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloud Provider Access Setup for Datalake
6 participants
@coderGo93 @MihaiBojin @themantissa @andreaangiolillo @leofigy @abner-dou