Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-172: chore changelog update for v0.8.1 #397

Merged
merged 2 commits into from
Jan 28, 2021
Merged

INTMDB-172: chore changelog update for v0.8.1 #397

merged 2 commits into from
Jan 28, 2021

Conversation

leofigy
Copy link
Contributor

@leofigy leofigy commented Jan 28, 2021

Description

Hi @themantissa , @coderGo93 this is the changelog for today's release, if you see it okay. I'll merge it and then hit the goreleaser

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • [X I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@leofigy leofigy changed the title CHORE: changelog update for v0.8.1 INTMDB-172: chore changelog update for v0.8.1 Jan 28, 2021
@leofigy leofigy self-assigned this Jan 28, 2021
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fast turn around time on these :)

CHANGELOG.md Outdated

- INTMDB-158: Added private endpoint in connection strings [\#392](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/392) ([coderGo93](https://github.com/coderGo93))
- INTMDB-163: Wrong order for PrivateLink Endpoint Service and detects unnecessary changes [\#388](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/388) ([coderGo93](https://github.com/coderGo93))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't appear for INTMDB-169 , is that normal?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @coderGo93 !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi It's added now, what happened is because we had a pre-release pre.2 , it seems the utility we use to generate this got confused , i.e

`- Managing encryption at rest using iam roles fails #382

  • Unable to use mongodbatlas_network_peering data source #377

Merged pull requests:

  • INTMDB-169: delete encoding url path in private endpoint service #393 (coderGo93)`

maybe a bug in the way the utility parses the pre tag

Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the update in changelog

@leofigy leofigy merged commit 9ea546e into master Jan 28, 2021
@leofigy leofigy deleted the INTMDB-172 branch January 28, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants