Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-162: Fixes bug about detecting changes and make sensitive values #383

Merged
merged 4 commits into from
Jan 18, 2021

Conversation

coderGo93
Copy link
Contributor

Description

Fixes the bug when it detects change even you didn't put new values, and make sensitive to parameters.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@coderGo93 coderGo93 self-assigned this Jan 16, 2021
@coderGo93 coderGo93 changed the title INTMDB-162: Fixes bug about detectin changes and make sensitive values INTMDB-162: Fixes bug about detecting changes and make sensitive values Jan 16, 2021
Copy link
Contributor

@leofigy leofigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@leofigy leofigy added the run-testacc To run acceptance tests label Jan 16, 2021
@leofigy leofigy merged commit 080d3b2 into master Jan 18, 2021
@leofigy leofigy deleted the INTMDB-162 branch January 18, 2021 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-testacc To run acceptance tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants