Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-141: Fixing 404 for existing database user #362

Merged
merged 1 commit into from
Dec 15, 2020
Merged

INTMDB-141: Fixing 404 for existing database user #362

merged 1 commit into from
Dec 15, 2020

Conversation

leofigy
Copy link
Contributor

@leofigy leofigy commented Dec 11, 2020 •
edited
Loading

Description

Hi @themantissa, @coderGo93

Minor fix, just updating the resource to reset the state in case it's not a new resource and was not found

Link to any related issue(s):

#360

Type of change:

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@leofigy leofigy changed the title Fixing 404 for existent resources to reset state Fixing 404 for existing database user Dec 11, 2020
@leofigy leofigy self-assigned this Dec 11, 2020
@leofigy leofigy added the run-testacc To run acceptance tests label Dec 11, 2020
@themantissa themantissa changed the title Fixing 404 for existing database user INTMDB-141: Fixing 404 for existing database user Dec 15, 2020
themantissa
themantissa approved these changes Dec 15, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

coderGo93
coderGo93 approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leofigy leofigy merged commit fea29d9 into master Dec 15, 2020
@leofigy leofigy deleted the issue-360 branch December 15, 2020 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderGo93 coderGo93 coderGo93 approved these changes

@themantissa themantissa themantissa approved these changes

Assignees

@leofigy leofigy

Labels
run-testacc To run acceptance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leofigy @themantissa @coderGo93