Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Sets correct zone_id when use_replication_spec_per_shard is false and refactors replica_set_scaling_strategy handling with old schema of advanced cluster #2568

Merged
merged 5 commits into from
Sep 9, 2024
Merged

fix: Sets correct zone_id when use_replication_spec_per_shard is false and refactors replica_set_scaling_strategy handling with old schema of advanced cluster #2568

merged 5 commits into from
Sep 9, 2024

Conversation

oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Sep 9, 2024 •
edited
Loading

Description

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@oarbusi oarbusi requested a review from a team as a code owner September 9, 2024 08:52
@oarbusi oarbusi changed the title chore: Refactors replica_set_scaling_strategy handling with old schema of advanced cluster bug: Sets correct zone_id when use_replication_spec_per_shard is false and refactors replica_set_scaling_strategy handling with old schema of advanced cluster Sep 9, 2024
@oarbusi oarbusi requested a review from a team as a code owner September 9, 2024 09:31
@oarbusi oarbusi changed the title bug: Sets correct zone_id when use_replication_spec_per_shard is false and refactors replica_set_scaling_strategy handling with old schema of advanced cluster fix: Sets correct zone_id when use_replication_spec_per_shard is false and refactors replica_set_scaling_strategy handling with old schema of advanced cluster Sep 9, 2024
@github-actions github-actions bot added the bug label Sep 9, 2024
lantoli
lantoli reviewed Sep 9, 2024
View reviewed changes
.changelog/2568.txt Outdated Show resolved Hide resolved
AgustinBettati
AgustinBettati approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the follow up and also fixing additional bug

@oarbusi oarbusi merged commit cac7b87 into master Sep 9, 2024
35 checks passed
@oarbusi oarbusi deleted the CLOUDP-261476-followup-commnets branch September 9, 2024 16:12
svc-apix-Bot added a commit that referenced this pull request Sep 9, 2024
@svc-apix-Bot
chore: Updates CHANGELOG.md for #2568
664d77c
lantoli added a commit that referenced this pull request Sep 10, 2024
@lantoli
Merge branch 'master' into CLOUDP-270155-access-dev
bf80b22 
* master:
  doc: Adds 1.19.0 release upgrade guide (#2564)
  chore: Updates CHANGELOG.md for #2528
  feat: Supports change_stream_options_pre_and_post_images_expire_after_seconds in `mongodbatlas_cluster` and `mongodbatlas_advanced_cluster` (#2528)
  chore: Disables preview mode for EAR private endpoint so it may be normally accessible (#2571)
  doc: Adds support for SDK_BRANCH in schema generation (#2562)
  update git workflow (#2572)
  chore: Updates CHANGELOG.md for #2566
  feat: Adds `mongodbatlas_stream_processor` resource and data sources (#2566)
  chore: Updates CHANGELOG.md for #2569
  chore: Merges Azure KMS Encryption at Rest Private Endpoint feature to master (#2569)
  chore: Updates CHANGELOG.md for #2568
  doc: Includes sync_creation into mongodbatlas_online_archive resource documentation (#2567)
  fix: Sets correct `zone_id` when `use_replication_spec_per_shard` is false and refactors `replica_set_scaling_strategy` handling with old schema of advanced cluster (#2568)
  chore: Updates CHANGELOG.md for #2539
  feat: Support `replica_set_scaling_strategy` in `mongodbatlas_advanced_cluster` (#2539)
  adding changelog entry for 1.18.1 to avoid confusion (#2561)

# Conflicts:
#	internal/provider/provider.go
lantoli added a commit that referenced this pull request Sep 10, 2024
@lantoli
Merge branch 'master' into CLOUDP-272251_employee_crd
98d9ced 
* master:
  doc: Adds 1.19.0 release upgrade guide (#2564)
  chore: Updates CHANGELOG.md for #2528
  feat: Supports change_stream_options_pre_and_post_images_expire_after_seconds in `mongodbatlas_cluster` and `mongodbatlas_advanced_cluster` (#2528)
  chore: Disables preview mode for EAR private endpoint so it may be normally accessible (#2571)
  doc: Adds support for SDK_BRANCH in schema generation (#2562)
  update git workflow (#2572)
  chore: Updates CHANGELOG.md for #2566
  feat: Adds `mongodbatlas_stream_processor` resource and data sources (#2566)
  chore: Updates CHANGELOG.md for #2569
  chore: Merges Azure KMS Encryption at Rest Private Endpoint feature to master (#2569)
  chore: Updates CHANGELOG.md for #2568
  doc: Includes sync_creation into mongodbatlas_online_archive resource documentation (#2567)
  fix: Sets correct `zone_id` when `use_replication_spec_per_shard` is false and refactors `replica_set_scaling_strategy` handling with old schema of advanced cluster (#2568)
  chore: Updates CHANGELOG.md for #2539
  feat: Support `replica_set_scaling_strategy` in `mongodbatlas_advanced_cluster` (#2539)
  adding changelog entry for 1.18.1 to avoid confusion (#2561)

# Conflicts:
#	internal/provider/provider.go
lantoli added a commit that referenced this pull request Sep 10, 2024
@lantoli
Merge branch 'master' into CLOUDP-270155-access-dev
8f04320 
* master:
  doc: Adds 1.19.0 release upgrade guide (#2564)
  chore: Updates CHANGELOG.md for #2528
  feat: Supports change_stream_options_pre_and_post_images_expire_after_seconds in `mongodbatlas_cluster` and `mongodbatlas_advanced_cluster` (#2528)
  chore: Disables preview mode for EAR private endpoint so it may be normally accessible (#2571)
  doc: Adds support for SDK_BRANCH in schema generation (#2562)
  update git workflow (#2572)
  chore: Updates CHANGELOG.md for #2566
  feat: Adds `mongodbatlas_stream_processor` resource and data sources (#2566)
  chore: Updates CHANGELOG.md for #2569
  chore: Merges Azure KMS Encryption at Rest Private Endpoint feature to master (#2569)
  chore: Updates CHANGELOG.md for #2568
  doc: Includes sync_creation into mongodbatlas_online_archive resource documentation (#2567)
  fix: Sets correct `zone_id` when `use_replication_spec_per_shard` is false and refactors `replica_set_scaling_strategy` handling with old schema of advanced cluster (#2568)
  chore: Updates CHANGELOG.md for #2539
  feat: Support `replica_set_scaling_strategy` in `mongodbatlas_advanced_cluster` (#2539)
  adding changelog entry for 1.18.1 to avoid confusion (#2561)

# Conflicts:
#	internal/provider/provider.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgustinBettati AgustinBettati AgustinBettati approved these changes

@pierwill pierwill pierwill approved these changes

@lantoli lantoli lantoli approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oarbusi @lantoli @pierwill @AgustinBettati