Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate: Deprecate ip_addresses attribute in project resource and data source #2541

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

rubenVB01
Copy link
Contributor

@rubenVB01 rubenVB01 commented Aug 30, 2024

Description

Deprecates ip_addresses in resource and datasource mongodbatlas_project

Agustin Edit:
Verified that with the new plan modifier configured in ip_addresses the plan no longer show details associated to this attribute. This will avoid further client confusion until the attribute is removed completely.
Screenshot 2024-09-03 at 11 25 57

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@rubenVB01 rubenVB01 requested review from a team as code owners August 30, 2024 13:18
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

Copy link
Collaborator

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@davidhou17 davidhou17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we apply the following clarifications across these descriptions?

.changelog/2541.txt Outdated Show resolved Hide resolved
docs/data-sources/project.md Outdated Show resolved Hide resolved
@AgustinBettati AgustinBettati merged commit a3585d0 into master Sep 4, 2024
35 checks passed
@AgustinBettati AgustinBettati deleted the CLOUDP-262915_deprecation_ipaddresses branch September 4, 2024 08:25
svc-apix-Bot added a commit that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants