feat: Updates mongodbatlas_encryption_at_rest resource to use new azure_key_vault_config.require_private_networking field

[maastha]

Description

Updates mongodbatlas_encryption_at_rest resource to use new azure_key_vault_config.require_private_networking field and updates tests.

Link to any related issue(s): CLOUDP-267658

Type of change:

• Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
• New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
• Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
• This change requires a documentation update
• Documentation fix/enhancement

Required Checklist:

• I have signed the MongoDB CLA
• I have read the contributing guides
• I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
• I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code
• If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
• If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

• Currently below error shows if user tries to enable the new flag without enabling the feature flag at project level:

      ~ azure_key_vault_config {
          ~ require_private_networking = false -> true
            # (9 unchanged attributes hidden)
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.
mongodbatlas_encryption_at_rest.test: Modifying... [id=6697e11ce89c955b64899b6d]
╷
│ Error: error updating encryption at rest
│ 
│   with mongodbatlas_encryption_at_rest.test,
│   on main.tf line 1, in resource "mongodbatlas_encryption_at_rest" "test":
│    1: resource "mongodbatlas_encryption_at_rest" "test" {
│ 
│ error updating Encryption At Rest: https://cloud-dev.mongodb.com/api/atlas/v2/groups/6697e11ce89c955b64899b6d/encryptionAtRest PATCH: HTTP 403 Forbidden (Error code:
│ "FEATURE_UNSUPPORTED") Detail: Feature not supported by current account level. Reason: Forbidden. Params: []

• All tests run locally:
  

[maastha]

mongodbatlas_cloud_provider_access resource doesn't exist anymore so this test hasn't been working for a while. Updated the config and moved to testAccMongoDBAtlasEncryptionAtRestConfigAwsKmsWithRole which creates all required resources.

[AgustinBettati]

LGTM, just small adjustment that I believe is needed in acceptance test

[AgustinBettati]

LGTM, left one follow up question

[AgustinBettati]

curious if this was needed to avoid non empty plans, or simply to remove noise in plan outputs.

[maastha]

Essentially if user just upgraded (i.e. this attribute doesn't exist in the state) and they make an update to their config then without the PlanModifier we get (known after apply):

 ~ azure_key_vault_config {
          ~ require_private_networking = false -> (known after apply)
          ~ tenant_id                  = (sensitive value)
            # (8 unchanged attributes hidden)
        }

[EspenAlbert]

I like this new explicit conversions 👍

[EspenAlbert]

LGTM!

[kanchana-mongodb]

LGTM