Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the name of module client mongodb atlas #244

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Updated the name of module client mongodb atlas #244

merged 1 commit into from
Jun 22, 2020

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Jun 15, 2020 •
edited
Loading

…ource/datasources

Description

Updated vendor/go.mod and changed the name of module of client mongo for all resources/datasources

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@coderGo93 coderGo93 self-assigned this Jun 15, 2020
@ghost ghost added the size/XL label Jun 15, 2020
themantissa
themantissa approved these changes Jun 15, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please ensure one DoU reviewer approves as well. Thank you!

@themantissa
Copy link
Collaborator

btw - may need to hold on merging this to 0.6.1 out.

PacoDw
PacoDw approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@PacoDw PacoDw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coderGo93 coderGo93 merged commit 7195fa6 into master Jun 22, 2020
@coderGo93 coderGo93 deleted the update-vanity-name branch June 22, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PacoDw PacoDw PacoDw approved these changes

@themantissa themantissa themantissa approved these changes

@marinsalinas marinsalinas Awaiting requested review from marinsalinas

@gmlp gmlp Awaiting requested review from gmlp

Assignees

@coderGo93 coderGo93

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coderGo93 @themantissa @PacoDw