fix: Correctly handle GCP updates of mongodbatlas_network_peering
#2306
Conversation
|
APIx bot: a message has been sent to Docs Slack channel |
| @@ -142,6 +142,52 @@ func TestAccNetworkRSNetworkPeering_basicGCP(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccNetworkRSNetworkPeering_updateBasicGCP(t *testing.T) { | |||
| acc.SkipTestForCI(t) // needs GCP configuration | |||
There was a problem hiding this comment.
is it doable to enable in CI or it's very complicated?
There was a problem hiding this comment.
I have run the tests but I have done it using my GCP account. If we are able to have a generic account for the team we could do it, but I didn't want to use my account credentials to run the tests in CI.
There was a problem hiding this comment.
that's for sure. maybe we can create a triage ticket to have test credentials in GCP
There was a problem hiding this comment.
I will create the ticket! Thanks
edit: created CLOUDP-250829
| @@ -142,6 +142,52 @@ func TestAccNetworkRSNetworkPeering_basicGCP(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccNetworkRSNetworkPeering_updateBasicGCP(t *testing.T) { | |||
There was a problem hiding this comment.
just to confirm, with the previous implementation this test was failing in the patch request right?
There was a problem hiding this comment.
Yes exactly. It was failing because update is not possible if the Status is Available
Co-authored-by: kanchana-mongodb <[email protected]>
Description
Correctly handle GCP updates of
mongodbatlas_network_peeringLink to any related issue(s): CLOUDP-250605
Type of change:
Required Checklist:
Further comments