Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes nil pointer dereference if advanced_configuration update fails in mongodbatlas_cluster #2139

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

maastha
Copy link
Collaborator

@maastha maastha commented Apr 11, 2024

Description

Fixes nil pointer exception if advanced_configuration update fails in mongodbatlas_cluster

Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-241758
Fixes #2122

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@github-actions github-actions bot added the bug label Apr 11, 2024
@maastha maastha changed the title fix: Fixes nil pointer exception if advanced_configuration update fails in mongodbatlas_cluster fix: Fixes nil pointer dereference if advanced_configuration update fails in mongodbatlas_cluster Apr 11, 2024
@maastha maastha marked this pull request as ready for review April 11, 2024 11:28
@maastha maastha requested review from a team as code owners April 11, 2024 11:28
Copy link
Collaborator

@oarbusi oarbusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔍

.changelog/2139.txt Outdated Show resolved Hide resolved
@maastha maastha merged commit 2e93b26 into master Apr 12, 2024
47 checks passed
@maastha maastha deleted the CLOUDP-241758-fix-cluster-error branch April 12, 2024 09:05
lantoli added a commit that referenced this pull request Apr 15, 2024
* master:
  fix: Removes default comment when creating resource `mongodbatlas_privatelink_endpoint_serverless` and adds update support to `mongodbatlas_privatelink_endpoint_service_serverless` (#2133)
  doc: Documents testing best practices (#2132)
  chore: Uses correct format when setting remote (#2147)
  chore: Configures git correctly for automatic commit (#2146)
  chore: Uses PAT of bot to commit changelog updates (#2144)
  doc: Adjust RELEASING.md documentation with new process (#2142)
  fix: Fixes nil pointer dereference if `advanced_configuration` update fails in `mongodbatlas_cluster` (#2139)
  chore: Adds a  new step in release process that marks Jira version as released (#2136)
  chore: Sends Slack notification when changelog update fails (#2140)
  chore: Adds new step in release process for updating header of changelog (#2134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: nil pointer dereference when setting "minimum_enabled_tls_protocol" to "TLS1_3"
4 participants