Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Follow up to use global mig project in tests #2068

Merged
merged 1 commit into from
Mar 25, 2024
Merged

chore: Follow up to use global mig project in tests #2068

merged 1 commit into from
Mar 25, 2024

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Mar 23, 2024 •
edited
Loading

Description

Follow up to use global mig project in tests

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@lantoli lantoli marked this pull request as ready for review March 25, 2024 06:59
@lantoli lantoli requested a review from a team as a code owner March 25, 2024 06:59
oarbusi
oarbusi reviewed Mar 25, 2024
View reviewed changes
internal/service/networkcontainer/resource_network_container_migration_test.go
@@ -13,7 +13,7 @@ import (

func TestMigNetworkContainer_basicAWS(t *testing.T) {
var (
projectID = acc.ProjectIDExecution(t)
projectID = acc.ProjectIDExecution(t) // No mig.ProjectIDGlobal because network container
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because network container is quite vague, could we maybe rephrase it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there can be only one container per project and provider / region. I wanted to find a balance of giving some clues explaining why we're not using the "expected" way but not being very verbose explaining the details of how Atlas works.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed offline we'll leave in this way

oarbusi
oarbusi reviewed Mar 25, 2024
View reviewed changes
...chive/resource_privatelink_endpoint_service_data_federation_online_archive_migration_test.go
@@ -11,7 +11,7 @@ import (

func TestMigNetworkPrivatelinkEndpointServiceDataFederationOnlineArchive_basic(t *testing.T) {
var (
projectID = acc.ProjectIDExecution(t)
projectID = acc.ProjectIDExecution(t) // No mig.ProjectIDGlobal because private link endpoint
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@lantoli lantoli merged commit 7ec51b7 into master Mar 25, 2024
63 checks passed
@lantoli lantoli deleted the mig_global_project branch March 25, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oarbusi oarbusi oarbusi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lantoli @oarbusi