-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Allows to to run acceptance tests for a published Atlas provider version #1789
Conversation
.github/workflows/test-suite.yml
Outdated
secrets: inherit | ||
uses: ./.github/workflows/acceptance-tests.yml | ||
with: | ||
ref: 'v1.14.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending to calculate instead of hardcoding
.github/workflows/test-suite.yml
Outdated
@@ -34,8 +34,16 @@ jobs: | |||
secrets: inherit | |||
uses: ./.github/workflows/cleanup-test-env.yml | |||
|
|||
acc-tests-latest-published: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am struggling to see the value of adding this job to run daily, given that the results will be the same unless there is a new patch release from TF.
If you can provide more context in the PR or reference where this requirement was discussed that would be great. I am thinking why we cannot rely on our master branch to see if the latest patch version of TF is breaking some functionality in our provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the use case here is that Hashicorp releases a new version, e.g. 1.6.7 and breaks our latest published version, e.g. 1.14.0. it's true that results won't change while Hashicorp doesn't publish a new version. But the alternative is that we have to be pending (or automate?) when a new version is published and then run on demand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zuhairahmed what do you think?
alternatively we can do that, don't run every night but on demand when we know that a new Hashicorp version came out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AgustinBettati at the moment I'll leave only the option to run it manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Allows to to run acceptance tests for a published Atlas provider version.
This allows to run acceptance test for already published MongoDB Atlas provider releases for a Terraform CLI version and check that it's compatible.
Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-219089
Type of change:
Required Checklist:
Further comments