Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unit test failure missing permission #1778

Merged
merged 2 commits into from
Dec 19, 2023
Merged

chore: unit test failure missing permission #1778

merged 2 commits into from
Dec 19, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Dec 19, 2023 •
edited
Loading

Description

This PR fixes this bug #1761
which is caused by error-resource-not-accessible-by-integration

This tool requires write permission, and that message means the requester does not have enough permission. Recently, GitHub sets permissions conservatively for newly created repositories. If it's a newly created repository, check your Settings > Actions > General > Workflow permissions, and make sure to enable read and write permissions.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@github-actions github-actions bot added the bug label Dec 19, 2023
@andreaangiolillo andreaangiolillo changed the title fix: unit test failure missing permission chore: unit test failure missing permission Dec 19, 2023
@github-actions github-actions bot added the bug label Dec 19, 2023
@andreaangiolillo andreaangiolillo changed the title chore: unit test failure missing permission chore: fix unit test failure missing permission Dec 19, 2023
@github-actions github-actions bot added the bug label Dec 19, 2023
@andreaangiolillo andreaangiolillo changed the title chore: fix unit test failure missing permission chore: unit test failure missing permission Dec 19, 2023
@andreaangiolillo andreaangiolillo marked this pull request as ready for review December 19, 2023 17:58
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner December 19, 2023 17:58
lantoli
lantoli reviewed Dec 19, 2023
View reviewed changes
.github/workflows/code-health.yml
@@ -37,6 +37,8 @@ jobs:
unit-test:
needs: build
runs-on: ubuntu-latest
permissions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I deleted this in a previous PR. do you mind to add a comment referencing the info

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, updated

@mongodb mongodb deleted a comment from github-actions bot Dec 19, 2023
@github-actions GitHub Actions
Copy link
Contributor

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion 31% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/dsschema 100% ✔
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/validate 68% ➖
github.com/mongodb/terraform-provider-mongodbatlas/internal/provider 7% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/accesslistapikey 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/advancedcluster 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/alertconfiguration 33% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/apikey 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/atlasuser 0% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/auditing 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/backupcompliancepolicy 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupschedule 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshot 5% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotexportbucket 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotexportjob 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotrestorejob 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudprovideraccess 4% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cluster 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/clusteroutagesimulation 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/customdbrole 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/customdnsconfigurationclusteraws 5% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/databaseuser 30% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/datalakepipeline 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/encryptionatrest 31% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/eventtrigger 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federateddatabaseinstance 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedquerylimit 4% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsidentityprovider 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgconfig 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgrolemapping 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/globalclusterconfig 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/ldapconfiguration 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/ldapverify 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/maintenancewindow 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/networkcontainer 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/networkpeering 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/onlinearchive 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/organization 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/orginvitation 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privateendpointregionalmode 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpoint 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointserverless 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointservice 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointservicedatafederationonlinearchive 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointserviceserverless 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/project 30% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectapikey 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectinvitation 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectipaccesslist 10% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/rolesorgid 7% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/searchdeployment 23% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/searchindex 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/serverlessinstance 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/streamconnection 26% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/streaminstance 14% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/teams 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/thirdpartyintegration 4% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/x509authenticationdatabaseuser 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/acc 4% ❌
Summary 7% (765 / 11018) ❌

@andreaangiolillo andreaangiolillo merged commit e63be0c into master Dec 19, 2023
30 checks passed
@andreaangiolillo andreaangiolillo deleted the fix_unit_test_failure branch December 19, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantoli lantoli lantoli approved these changes

@marcosuma marcosuma Awaiting requested review from marcosuma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @lantoli