Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Uses only latest provider version for Test Suite workflow #1777

Merged
merged 7 commits into from
Dec 20, 2023
Merged

chore: Uses only latest provider version for Test Suite workflow #1777

merged 7 commits into from
Dec 20, 2023

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Dec 19, 2023 •
edited
Loading

Description

Uses only latest provider version for Test Suite workflow.

Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-218767

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@lantoli lantoli marked this pull request as ready for review December 19, 2023 16:50
@lantoli lantoli requested a review from a team as a code owner December 19, 2023 16:50
@github-actions GitHub Actions
Copy link
Contributor

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion 31% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/dsschema 100% ✔
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/validate 68% ➖
github.com/mongodb/terraform-provider-mongodbatlas/internal/provider 7% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/accesslistapikey 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/advancedcluster 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/alertconfiguration 33% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/apikey 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/atlasuser 0% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/auditing 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/backupcompliancepolicy 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupschedule 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshot 5% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotexportbucket 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotexportjob 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotrestorejob 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudprovideraccess 4% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cluster 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/clusteroutagesimulation 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/customdbrole 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/customdnsconfigurationclusteraws 5% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/databaseuser 30% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/datalakepipeline 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/encryptionatrest 31% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/eventtrigger 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federateddatabaseinstance 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedquerylimit 4% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsidentityprovider 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgconfig 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgrolemapping 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/globalclusterconfig 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/ldapconfiguration 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/ldapverify 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/maintenancewindow 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/networkcontainer 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/networkpeering 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/onlinearchive 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/organization 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/orginvitation 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privateendpointregionalmode 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpoint 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointserverless 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointservice 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointservicedatafederationonlinearchive 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointserviceserverless 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/project 30% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectapikey 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectinvitation 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectipaccesslist 10% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/rolesorgid 7% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/searchdeployment 23% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/searchindex 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/serverlessinstance 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/streamconnection 26% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/streaminstance 14% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/teams 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/thirdpartyintegration 4% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/x509authenticationdatabaseuser 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/acc 4% ❌
Summary 7% (765 / 11018) ❌

andreaangiolillo
andreaangiolillo approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RELEASING.md Outdated


#### Update Test Suite versions
- Update [Test Suite workflow](https://github.com/mongodb/terraform-provider-mongodbatlas/blob/master/.github/workflows/test-suite.yml) if needed. Check `provider_matrix` and `schedule_provider_matrix` to make sure that they include the latest patch of the latest 2 provider versions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what the latest patch of the latest 2 provider versions means 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right it's confusing. what about this? "... the latest patch version release of the latest 2 major versions"

at this moment, the 2 latest versions of the provider are 1.14.x and 1.13.x, and the latest patches make: 1.14.0, 1.13.1

do you have any suggestion?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can also provide an example

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally we decided to use only the latest one at the moment

@lantoli lantoli force-pushed the CLOUDP-218767_doc_test_suite branch from 0a79738 to 5ce8ce8 Compare December 20, 2023 21:17
@lantoli lantoli changed the title chore: Updates release doc about reviewing Test Suite workflow chore: Uses only latest provider version for Test Suite workflow Dec 20, 2023
@lantoli lantoli merged commit f302d2e into master Dec 20, 2023
39 of 45 checks passed
@lantoli lantoli deleted the CLOUDP-218767_doc_test_suite branch December 20, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lantoli @andreaangiolillo