Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: define atlas stream functionality under beta flag environment variable #1726

Merged
merged 1 commit into from
Dec 11, 2023
Merged

chore: define atlas stream functionality under beta flag environment variable #1726

merged 1 commit into from
Dec 11, 2023

Conversation

AgustinBettati
Copy link
Member

Description

Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-216425

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion 31% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/dsschema 100% ✔
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/validate 68% ➖
github.com/mongodb/terraform-provider-mongodbatlas/internal/provider 7% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/accesslistapikey 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/advancedcluster 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/alertconfiguration 33% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/apikey 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/atlasuser 0% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/auditing 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/backupcompliancepolicy 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupschedule 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshot 5% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotexportbucket 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotexportjob 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudbackupsnapshotrestorejob 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cloudprovideraccess 4% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cluster 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/clusteroutagesimulation 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/customdbrole 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/customdnsconfigurationclusteraws 5% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/databaseuser 0% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/datalakepipeline 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/encryptionatrest 0% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/eventtrigger 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federateddatabaseinstance 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedquerylimit 4% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsidentityprovider 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgconfig 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgrolemapping 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/globalclusterconfig 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/ldapconfiguration 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/ldapverify 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/maintenancewindow 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/networkcontainer 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/networkpeering 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/onlinearchive 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/organization 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/orginvitation 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privateendpointregionalmode 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpoint 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointserverless 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointservice 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointservicedatafederationonlinearchive 3% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/privatelinkendpointserviceserverless 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/project 28% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectapikey 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectinvitation 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectipaccesslist 0% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/rolesorgid 7% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/searchdeployment 23% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/searchindex 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/serverlessinstance 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/streaminstance 14% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/teams 1% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/thirdpartyintegration 4% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/x509authenticationdatabaseuser 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/acc 5% ❌
Summary 5% (579 / 10825) ❌

@AgustinBettati AgustinBettati marked this pull request as ready for review December 7, 2023 16:33
@AgustinBettati AgustinBettati requested a review from a team as a code owner December 7, 2023 16:33
Zuhairahmed
Zuhairahmed approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, otherwise LGTM

website/docs/r/stream_instance.html.markdown
@@ -10,8 +10,7 @@ Provides a Stream Instance resource.

`mongodbatlas_stream_instance` provides a Stream Instance resource. The resource lets you create, edit, and delete stream instances in a project.

-> **NOTE:** To learn more about stream processing and existing limitations, see the [Atlas Stream Processing Documentation](https://www.mongodb.com/docs/atlas/atlas-sp/overview/#atlas-stream-processing-overview).

-> **NOTE:** Atlas Streams is currently in Preview, you'll need to set the environment variable `MONGODB_ATLAS_ENABLE_BETA=true` to use this resource. To learn more about stream processing and existing limitations, see the [Atlas Stream Processing Documentation](https://www.mongodb.com/docs/atlas/atlas-sp/overview/#atlas-stream-processing-overview).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this same doc comment to Atlas Stream Connection data sources and resource as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it will be included, it is not in this PR because stream connection resource and data source have not yet been implemented.

@AgustinBettati AgustinBettati merged commit 3d397f8 into master Dec 11, 2023
@AgustinBettati AgustinBettati deleted the CLOUDP-216425 branch December 11, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zuhairahmed Zuhairahmed Zuhairahmed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AgustinBettati @Zuhairahmed