fix: : Provider crash when an invalid role name is specified to mongodbatlas_project_api_key

[andreaangiolillo]

Description

Ticket: CLOUDP-216402
Issue: Provider crashes when an invalid role name is specified to mongodbatlas_project_api_key

Type of change:

• Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
• New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
• Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
• This change requires a documentation update
• Documentation fix/enhancement

Required Checklist:

• I have signed the MongoDB CLA
• I have read the contribution guidelines
• I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
• I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code
• If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Testing

Local testing

I reproduced the error with v1.13.1

│ Error: Plugin did not respond
--
│
│ The plugin encountered an error, and failed to respond to the
│ plugin6.(*GRPCProvider).ApplyResourceChange call. The plugin logs may
│ contain more details.

I run the same TF config with my changes

│ Error: POST https://cloud-dev.mongodb.com/api/atlas/v1.0/groups/6571a9637db22d780f3cec0c/apiKeys: 400 (request "INVALID_ENUM_VALUE") An invalid enumeration value GROUP_s was specified.

Acceptance Test

I added the acceptance test TestAccConfigRSProjectAPIKey_Invalid_Role

--- PASS: TestAccConfigRSProjectAPIKey_Invalid_Role (407.53s)
PASS
ok      github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectapikey       407.977s

[andreaangiolillo]

Failing test is related to another resource

Error: -08T10:39:12.578Z [ERROR] sdk.helper_resource: Error running import: test_name=TestAccConfigRSCustomDBRoles_importBasic test_terraform_path=/home/runner/work/_temp/035a6132-4f93-460b-8080-7c833c37c596/terraform test_working_directory=/tmp/plugintest409873591 test_step_number=2
  error=
  | ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
  | 
  |   map[string]string{
  | + \t"actions.0.resources.0.cluster": "false",
  |   }
  
=== NAME  TestAccConfigRSCustomDBRoles_importBasic
    resource_custom_db_role_test.go:441: Step 2/2 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        + 	"actions.0.resources.0.cluster": "false",
          }
--- FAIL: TestAccConfigRSCustomDBRoles_importBasic (417.32s)

[maastha]

In what case will orgID be ""? I believe this is what crashes the provider right (empty orgId passed to Delete API call)?

[andreaangiolillo]

The error in the help ticket was caused by the missing return statement at line 108: the endpoint was returning an error which was different than 404 and so line 126 was trying to access apiKey via apiKey.PublicKey but apiKey was null

I discovered this scenario on missing orgID with this failing test TestAccConfigRSProjectAPIKey_RecreateWhenDeletedExternally:

=== NAME  TestAccConfigRSProjectAPIKey_RecreateWhenDeletedExternally
    testing_new.go:91: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: error unable to delete Key (6571df9493323a7823188b59): DELETE https://cloud-dev.mongodb.com/api/atlas/v1.0/orgs//apiKeys/6571df9493323a7823188b59: 400 (request "") 

The test was deleting the API key manually as part of deleteAPIKeyManually and then the post-destroy was trying to delete the API key that was already deleted.