Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: handles paused clusters with errors when updating. #1640

Merged
merged 13 commits into from
Nov 21, 2023
Merged

fix!: handles paused clusters with errors when updating. #1640

merged 13 commits into from
Nov 21, 2023

Conversation

marcosuma
Copy link
Collaborator

@marcosuma marcosuma commented Nov 20, 2023 •
edited
Loading

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s): https://jira.mongodb.org/browse/INTMDB-1307

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@github-actions github-actions bot added the bug label Nov 20, 2023
@marcosuma
Copy link
Collaborator Author

I tried to fix the same for cluster but APIs and logic inside are different than advanced_cluster - a fix would probably make it worse instead of better.

@marcosuma marcosuma marked this pull request as ready for review November 21, 2023 08:04
@marcosuma marcosuma requested a review from a team as a code owner November 21, 2023 08:04
oarbusi
oarbusi approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@oarbusi oarbusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68% ➖
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/testutils 46% ❌
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 17% ❌
Summary 3% (284 / 10536) ❌

andreaangiolillo
andreaangiolillo approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the clarification

@marcosuma marcosuma changed the title fix: handles paused clusters with errors when updating. fix! handles paused clusters with errors when updating. Nov 21, 2023
@marcosuma marcosuma changed the title fix! handles paused clusters with errors when updating. fix!: handles paused clusters with errors when updating. Nov 21, 2023
lantoli
lantoli approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@lantoli lantoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fill the PR description

@andreaangiolillo andreaangiolillo changed the title fix!: handles paused clusters with errors when updating. fix: handles paused clusters with errors when updating. Nov 21, 2023
@andreaangiolillo andreaangiolillo changed the title fix: handles paused clusters with errors when updating. fix!: handles paused clusters with errors when updating. Nov 21, 2023
@marcosuma marcosuma merged commit 4a24fdc into master Nov 21, 2023
35 of 36 checks passed
@marcosuma marcosuma deleted the HELP-52480-paused-clusters branch November 21, 2023 16:50
@andreaangiolillo andreaangiolillo mentioned this pull request Nov 23, 2023
Merged
12 tasks
zach-carr pushed a commit to zach-carr/terraform-provider-mongodbatlas that referenced this pull request Feb 14, 2024
@oarbusi @AgustinBettati
doc: upgrade guide for v1.13.0 (mongodb#1659)
c88105a 
* initial commit for upgrade guide 1.13.0

* fix version

* Update website/docs/guides/1.13.0-upgrade-guide.html.markdown

Co-authored-by: Agustin Bettati <[email protected]>

* add breaking changes section with mongodb#1640

---------

Co-authored-by: Agustin Bettati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oarbusi oarbusi oarbusi approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@lantoli lantoli lantoli approved these changes

Assignees
No one assigned
Labels
breaking-change bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcosuma @lantoli @andreaangiolillo @oarbusi