-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update atlas-sdk to v20231001001 #1515
Conversation
|
@@ -244,7 +244,7 @@ func resourceMongoDBAtlasProjectAPIKeyUpdate(ctx context.Context, d *schema.Reso | |||
|
|||
if d.HasChange("description") { | |||
newDescription := d.Get("description").(string) | |||
if _, _, err := connV2.ProgrammaticAPIKeysApi.UpdateApiKeyRoles(ctx, projectID, apiKeyID, &admin.CreateAtlasProjectApiKey{ | |||
if _, _, err := connV2.ProgrammaticAPIKeysApi.UpdateApiKeyRoles(ctx, projectID, apiKeyID, &admin.UpdateAtlasProjectApiKey{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this change wanted? we don't have the create CreateAtlasProjectApiKey
function anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a naming change that is aligned with the operation. The structure of admin.CreateAtlasProjectApiKey
and admin.UpdateAtlasProjectApiKey
are identical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AgustinBettati Could you check that errors are caused by cloud-dev? |
Confirmed it is cloud-dev related, have reach out to the team. |
cloud-dev stable again, all 🟢 |
Description
Update to latest atlas-sdk version https://github.com/mongodb/atlas-sdk-go/releases/tag/v20231001001.0.0
Type of change:
Required Checklist:
Further comments