Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update 1.10.0-upgrade-guide.html.markdown #1511

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

Zuhairahmed
Copy link
Contributor

@Zuhairahmed Zuhairahmed commented Oct 6, 2023

proper name of parameter is retain_backups_enabled in Terraform, not retainBackups

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@Zuhairahmed Zuhairahmed requested a review from a team as a code owner October 6, 2023 16:01
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 20%
Summary 3% (271 / 10279)

@andreaangiolillo andreaangiolillo changed the title Update 1.10.0-upgrade-guide.html.markdown doc: Update 1.10.0-upgrade-guide.html.markdown Oct 9, 2023
@andreaangiolillo andreaangiolillo merged commit 1100e25 into master Oct 13, 2023
@andreaangiolillo andreaangiolillo deleted the upgradeGuideDocFix branch October 13, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants