Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: module naming convention #1500

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix: module naming convention #1500

merged 1 commit into from
Sep 28, 2023

Conversation

govardhanpagidi
Copy link
Contributor

@govardhanpagidi govardhanpagidi commented Sep 28, 2023 •
edited
Loading

fix: module naming convention

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@govardhanpagidi govardhanpagidi requested a review from a team as a code owner September 28, 2023 14:31
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2% ❌
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68% ➖
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 20% ❌
Summary 3% (279 / 10572) ❌

andreaangiolillo
andreaangiolillo approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@govardhanpagidi govardhanpagidi merged commit 2965bc9 into master Sep 28, 2023
21 checks passed
@govardhanpagidi govardhanpagidi deleted the module-naming-convention branch September 28, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@govardhanpagidi @andreaangiolillo