-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add coverage report to PRs #1496
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Does this include coverage via acceptance tests as well or only unit tests? Because we mainly have acceptance tests |
Unit tests as they are the ones that run for all the PRs. Having something similar for acceptance tests would mean running all the acceptance tests for all the PRs at all times which is something that we don't want to do. Feel free to create a ticket to investigate a way to include acceptance test coverage if you think we should do it |
Description
This PR updates the
unit-test
action to generate and include the coverage report in the PR.This change was discussed as part of the Engineering Proposal (comment)
Note:
Once the PR is merged, the following PRs will get an additional Column
Branch Rate
that shows the coverage in the branch vs PR as shown in https://github.com/irongut/CodeCoverageSummary#markdown-exampleLink to any related issue(s):
Type of change:
Required Checklist:
Further comments