Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add coverage report to PRs #1496

Merged
merged 8 commits into from
Sep 26, 2023
Merged

feat: add coverage report to PRs #1496

merged 8 commits into from
Sep 26, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Sep 25, 2023

Description

This PR updates the unit-test action to generate and include the coverage report in the PR.

This change was discussed as part of the Engineering Proposal (comment)

Note:

Once the PR is merged, the following PRs will get an additional Column Branch Rate that shows the coverage in the branch vs PR as shown in https://github.com/irongut/CodeCoverageSummary#markdown-example

Screenshot 2023-09-25 at 15 14 23

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@andreaangiolillo andreaangiolillo changed the title feat: add coverage feat: add coverage report to PRs Sep 25, 2023
@mongodb mongodb deleted a comment from github-actions bot Sep 25, 2023
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 20%
Summary 3% (279 / 10571)

@andreaangiolillo andreaangiolillo marked this pull request as ready for review September 25, 2023 14:07
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner September 25, 2023 14:07
Copy link
Collaborator

@marcosuma marcosuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maastha
Copy link
Collaborator

maastha commented Sep 25, 2023

Does this include coverage via acceptance tests as well or only unit tests? Because we mainly have acceptance tests

@andreaangiolillo
Copy link
Collaborator Author

andreaangiolillo commented Sep 25, 2023

Does this include coverage via acceptance tests as well or only unit tests? Because we mainly have acceptance tests

Unit tests as they are the ones that run for all the PRs. Having something similar for acceptance tests would mean running all the acceptance tests for all the PRs at all times which is something that we don't want to do. Feel free to create a ticket to investigate a way to include acceptance test coverage if you think we should do it

@andreaangiolillo andreaangiolillo merged commit 86ac961 into master Sep 26, 2023
23 checks passed
@andreaangiolillo andreaangiolillo deleted the feat_coverage branch September 26, 2023 08:00
@AgustinBettati AgustinBettati mentioned this pull request Mar 11, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants