Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add datasetName to storage_databases.collections.data_sources in mongodbatlas_federated_database_instance #1439

Merged
merged 22 commits into from
Sep 4, 2023
Merged

feat: Add datasetName to storage_databases.collections.data_sources in mongodbatlas_federated_database_instance #1439

merged 22 commits into from
Sep 4, 2023

Conversation

maastha
Copy link
Collaborator

@maastha maastha commented Sep 1, 2023 •
edited
Loading

Description

Add datasetName to storage_databases.collections.data_sources in mongodbatlas_federated_database_instance
Link to any related issue(s): INTMDB-1038

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Testing

Plan and successful apply with new parameter:
Screenshot 2023-09-01 at 10 54 56

.tfstate file after successful apply:
Screenshot 2023-09-01 at 10 55 20

@maastha maastha changed the title INTMDB-1038 Add datasetName to storage_databases.collections.data_sources in mongodbatlas_federated_database_instance feat: Add datasetName to storage_databases.collections.data_sources in mongodbatlas_federated_database_instance Sep 1, 2023
@maastha maastha marked this pull request as ready for review September 1, 2023 11:34
@maastha maastha requested a review from a team as a code owner September 1, 2023 11:34
@maastha maastha requested a review from Zuhairahmed September 1, 2023 12:13
andreaangiolillo
andreaangiolillo approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Zuhairahmed
Zuhairahmed approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this one too, let's add INTMDB ticket link to PR description. Otherwise LGTM!

Base automatically changed from INTMDB-1036-federated-instance-to-new-SDK to master September 4, 2023 08:01
@maastha
Copy link
Collaborator Author

maastha commented Sep 4, 2023

Merging as cloud-dev is down, have run the tests locally.

@maastha maastha merged commit 7e0d8d7 into master Sep 4, 2023
@maastha maastha deleted the INTMDB-1038-add-datasetName-federated-instance_2 branch September 4, 2023 10:03
andreaangiolillo pushed a commit that referenced this pull request Sep 7, 2023
@maastha @andreaangiolillo
feat: Add datasetName to storage_databases.collections.data_sources i…
63752d1 
…n mongodbatlas_federated_database_instance (#1439)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@Zuhairahmed Zuhairahmed Zuhairahmed approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maastha @andreaangiolillo @Zuhairahmed