-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extract Configure and Metadata framework functions into single implementation #1424
refactor: extract Configure and Metadata framework functions into single implementation #1424
Conversation
…gle implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. My comments are not blocking the PR
@@ -0,0 +1,68 @@ | |||
package mongodbatlas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to move this struct in a subdir to make it clear that does not define a resource or ds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had looked into this but reached a limitation. When defining fw_common.go
within framework package, I need to import mongodbatlas package to reference MongoDBClient
. This leads to an import cycle not allowed
error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for this one!
cd37419
into
CLOUDP-189585-plugin-framework-migration
Description
Small refactor that removes boilerplate definition of
Metadata
andConfigure
functions in all our plugin-framework resources and data sources into common structs.Type of change:
Required Checklist:
Further comments