-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate DataSource: mongodbatlas_project_ip_access_list to Terraform Plugin Framework #1395
Merged
andreaangiolillo
merged 9 commits into
CLOUDP-189585-plugin-framework-migration
from
INTMDB-975_2
Aug 22, 2023
Merged
feat: Migrate DataSource: mongodbatlas_project_ip_access_list to Terraform Plugin Framework #1395
andreaangiolillo
merged 9 commits into
CLOUDP-189585-plugin-framework-migration
from
INTMDB-975_2
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aform Plugin Framework
@@ -0,0 +1,61 @@ | |||
package validator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added unit tests to the validators
maastha
reviewed
Aug 21, 2023
mongodbatlas/fw_data_source_mongodbatlas_project_ip_access_list.go
Outdated
Show resolved
Hide resolved
mongodbatlas/fw_data_source_mongodbatlas_project_ip_access_list.go
Outdated
Show resolved
Hide resolved
…t.go Co-authored-by: maastha <[email protected]>
mongodbatlas/fw_data_source_mongodbatlas_project_ip_access_list_migration_test.go
Outdated
Show resolved
Hide resolved
AgustinBettati
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing comments from my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: INTMDB-975
This PR migrates
mongodbatlas_project_ip_access_list
to the new frameworkType of change:
Required Checklist:
Further comments
Testing
In addition to the added acceptance tests I tested the data source locally in the following scenario:
tf plan
and verify plan was emptytf plan
tf state