-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Migrate mongodbatlas_encryption_at_rest to Terraform Plugin Framework #1383
refactor: Migrate mongodbatlas_encryption_at_rest to Terraform Plugin Framework #1383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
strings.Contains(err.Error(), "CLOUD_PROVIDER_ACCESS_ROLE_NOT_AUTHORIZED") { | ||
log.Printf("warning issue performing authorize EncryptionsAtRest not done try again: %s \n", err.Error()) | ||
log.Println("retrying ") | ||
time.Sleep(10 * time.Second) | ||
encryptionAtRestReq.GroupID = projectID | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this logic already here? Can we use retry.StateChangeConf
instead? you can file a ticket to improve the logic to use retry.StateChangeConf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this has been migrated as is. Created https://jira.mongodb.org/browse/INTMDB-1039
Co-authored-by: Agustin Bettati <[email protected]> Co-authored-by: Andrea Angiolillo <[email protected]>
Description
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments
Migration and acceptance tests run locally:
Import:
Resource in state after import: