Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-926: Mark instance_size in electable specs required in advanced_cluster documentation #1339

Merged
merged 1 commit into from
Jul 21, 2023
Merged

INTMDB-926: Mark instance_size in electable specs required in advanced_cluster documentation #1339

merged 1 commit into from
Jul 21, 2023

Conversation

maastha
Copy link
Collaborator

@maastha maastha commented Jul 21, 2023 •
edited
Loading

Description

instance_size for advance cluster marked as optional in the documentation which is incorrect. This PR updates documentation to make it Required.

Link to any related issue(s): INTMDB-926
#1311

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@maastha maastha marked this pull request as ready for review July 21, 2023 13:00
@maastha maastha requested a review from a team as a code owner July 21, 2023 13:00
andreaangiolillo
andreaangiolillo approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left only one question to check if the other cluster resource has the same problem

@maastha maastha merged commit fa9746c into master Jul 21, 2023
@maastha maastha deleted the INTMDB-926 branch July 21, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@wtrocki wtrocki wtrocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maastha @wtrocki @andreaangiolillo