Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-923: [Terraform] Add Autogenerated SDK to Terraform #1309

Merged
merged 9 commits into from
Jul 19, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jul 11, 2023

Description

Ticket: INTMDB-923

This PR adds the atlas-sdk-go to the provider.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo marked this pull request as ready for review July 11, 2023 09:23
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner July 11, 2023 09:23
@andreaangiolillo andreaangiolillo requested a review from wtrocki July 11, 2023 09:23
// Config struct ...
const ToolName = "terraform-provider-mongodbatlas"

var userAgent = fmt.Sprintf("%s/%s (%s;%s)", ToolName, version.ProviderVersion, runtime.GOOS, runtime.GOARCH)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good change to extend the format of the agent. Before we merge we need change our user agent's reference to cover it and telemetry team to update their search queries

Copy link
Collaborator Author

@andreaangiolillo andreaangiolillo Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I will revert this change and create a JIRA ticket to do this for TF and CFN so that PMs are all aware of this change and we can notify who is using the queries.

mongodbatlas/config.go Outdated Show resolved Hide resolved
mongodbatlas/config.go Outdated Show resolved Hide resolved
Copy link
Member

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome change!

@andreaangiolillo andreaangiolillo added the run-testacc To run acceptance tests label Jul 14, 2023
Copy link
Collaborator

@maastha maastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 9cef221 into master Jul 19, 2023
@andreaangiolillo andreaangiolillo deleted the INTMDB-923 branch July 19, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-testacc To run acceptance tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants