Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corrected documentation for the advance cluster and cluster #1167

Merged
merged 1 commit into from
May 23, 2023
Merged

corrected documentation for the advance cluster and cluster #1167

merged 1 commit into from
May 23, 2023

Conversation

nikhil-mongo
Copy link
Collaborator

@nikhil-mongo nikhil-mongo commented May 16, 2023 •
edited
Loading

Description

corrected documentation for the advance cluster and cluster timeout argument.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@nikhil-mongo nikhil-mongo requested a review from a team as a code owner May 16, 2023 10:31
gssbzn
gssbzn approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zuhairahmed Zuhairahmed changed the base branch from master to release-staging-v.1.10.0 May 17, 2023 03:42
@Zuhairahmed Zuhairahmed changed the base branch from release-staging-v.1.10.0 to master May 17, 2023 03:43
@Zuhairahmed
Copy link
Contributor

Thank you @nikhil-mongo for PR!

@Zuhairahmed
Copy link
Contributor

Feel free to merge @andreaangiolillo if no concerns!

@andreaangiolillo andreaangiolillo merged commit fead365 into mongodb:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@Zuhairahmed Zuhairahmed Zuhairahmed approved these changes

@zach-carr zach-carr Awaiting requested review from zach-carr

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikhil-mongo @Zuhairahmed @gssbzn @andreaangiolillo