-
Notifications
You must be signed in to change notification settings - Fork 178
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Uses
overwriteBackupPolicies in `mongodbatlas_backup_complianc…
…e_policy` to avoid overwriting non complying backup policies in updates (#2054)
- Loading branch information
Showing
2 changed files
with
182 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,10 +4,12 @@ import ( | |
| "context" | ||
| "fmt" | ||
| "os" | ||
| "regexp" | ||
| "testing" | ||
|
|
||
| "github.com/hashicorp/terraform-plugin-testing/helper/resource" | ||
| "github.com/hashicorp/terraform-plugin-testing/terraform" | ||
|
|
||
| "github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion" | ||
| "github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/acc" | ||
| ) | ||
|
|
@@ -41,7 +43,7 @@ func TestAccGenericBackupRSBackupCompliancePolicy_basic(t *testing.T) { | |
| }) | ||
| } | ||
|
|
||
| func TestAccGenericBackupRSBackupCompliancePolicy_withFirstLastName(t *testing.T) { | ||
| func TestAccGenericBackupRSBackupCompliancePolicy_update(t *testing.T) { | ||
| var ( | ||
| orgID = os.Getenv("MONGODB_ATLAS_ORG_ID") | ||
| projectOwnerID = os.Getenv("MONGODB_ATLAS_PROJECT_OWNER_ID") | ||
|
|
@@ -53,6 +55,17 @@ func TestAccGenericBackupRSBackupCompliancePolicy_withFirstLastName(t *testing.T | |
| ProtoV6ProviderFactories: acc.TestAccProviderV6Factories, | ||
| CheckDestroy: checkDestroy, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: configWithoutOptionals(projectName, orgID, projectOwnerID), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| checkExists(resourceName), | ||
| resource.TestCheckResourceAttr(resourceName, "authorized_user_first_name", "First"), | ||
| resource.TestCheckResourceAttr(resourceName, "authorized_user_last_name", "Last"), | ||
| resource.TestCheckResourceAttr(resourceName, "pit_enabled", "false"), | ||
| resource.TestCheckResourceAttr(resourceName, "encryption_at_rest_enabled", "false"), | ||
| resource.TestCheckResourceAttr(resourceName, "copy_protection_enabled", "false"), | ||
| ), | ||
| }, | ||
| { | ||
| Config: configBasic(projectName, orgID, projectOwnerID), | ||
| Check: resource.ComposeTestCheckFunc( | ||
|
|
@@ -65,6 +78,150 @@ func TestAccGenericBackupRSBackupCompliancePolicy_withFirstLastName(t *testing.T | |
| }) | ||
| } | ||
|
|
||
| func TestAccGenericBackupRSBackupCompliancePolicy_overwriteBackupPolicies(t *testing.T) { | ||
| var ( | ||
| orgID = os.Getenv("MONGODB_ATLAS_ORG_ID") | ||
| projectOwnerID = os.Getenv("MONGODB_ATLAS_PROJECT_OWNER_ID") | ||
| projectName = acc.RandomProjectName() | ||
| ) | ||
|
|
||
| resource.ParallelTest(t, resource.TestCase{ | ||
| PreCheck: func() { acc.PreCheckBasic(t) }, | ||
| ProtoV6ProviderFactories: acc.TestAccProviderV6Factories, | ||
| CheckDestroy: checkDestroy, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: configClusterWithBackupSchedule(projectName, orgID, projectOwnerID), | ||
| }, | ||
| { | ||
| Config: configOverwriteIncompatibleBackupPoliciesError(projectName, orgID, projectOwnerID), | ||
| ExpectError: regexp.MustCompile(`BACKUP_POLICIES_NOT_MEETING_BACKUP_COMPLIANCE_POLICY_REQUIREMENTS`), | ||
| }, | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| func configOverwriteIncompatibleBackupPoliciesError(projectName, orgID, projectOwnerID string) string { | ||
| return acc.ConfigProjectWithSettings(projectName, orgID, projectOwnerID, false) + ` | ||
| resource "mongodbatlas_cluster" "test" { | ||
| project_id = mongodbatlas_project.test.id | ||
| name = "test1" | ||
| provider_name = "AWS" | ||
| cluster_type = "REPLICASET" | ||
| mongo_db_major_version = "6.0" | ||
| provider_instance_size_name = "M10" | ||
| auto_scaling_compute_enabled = false | ||
| cloud_backup = true | ||
| auto_scaling_disk_gb_enabled = true | ||
| disk_size_gb = 12 | ||
| provider_volume_type = "STANDARD" | ||
| retain_backups_enabled = true | ||
| advanced_configuration { | ||
| oplog_min_retention_hours = 8 | ||
| } | ||
| replication_specs { | ||
| num_shards = 1 | ||
| regions_config { | ||
| region_name = "US_EAST_1" | ||
| electable_nodes = 3 | ||
| priority = 7 | ||
| read_only_nodes = 0 | ||
| } | ||
| } | ||
| } | ||
| resource "mongodbatlas_cloud_backup_schedule" "test" { | ||
| cluster_name = mongodbatlas_cluster.test.name | ||
| project_id = mongodbatlas_project.test.id | ||
| reference_hour_of_day = 3 | ||
| reference_minute_of_hour = 45 | ||
| restore_window_days = 2 | ||
| copy_settings { | ||
| cloud_provider = "AWS" | ||
| frequencies = ["DAILY"] | ||
| region_name = "US_WEST_1" | ||
| replication_spec_id = one(mongodbatlas_cluster.test.replication_specs).id | ||
| should_copy_oplogs = false | ||
| } | ||
| } | ||
| resource "mongodbatlas_backup_compliance_policy" "test" { | ||
| project_id = mongodbatlas_project.test.id | ||
| authorized_email = "[email protected]" | ||
| authorized_user_first_name = "First" | ||
| authorized_user_last_name = "Last" | ||
| copy_protection_enabled = true | ||
| pit_enabled = false | ||
| encryption_at_rest_enabled = false | ||
| on_demand_policy_item { | ||
| frequency_interval = 1 | ||
| retention_unit = "days" | ||
| retention_value = 1 | ||
| } | ||
| policy_item_daily { | ||
| frequency_interval = 1 | ||
| retention_unit = "days" | ||
| retention_value = 1 | ||
| } | ||
| } | ||
| ` | ||
| } | ||
|
|
||
| func configClusterWithBackupSchedule(projectName, orgID, projectOwnerID string) string { | ||
| return acc.ConfigProjectWithSettings(projectName, orgID, projectOwnerID, false) + ` | ||
| resource "mongodbatlas_cluster" "test" { | ||
| project_id = mongodbatlas_project.test.id | ||
| name = "test1" | ||
| provider_name = "AWS" | ||
| cluster_type = "REPLICASET" | ||
| mongo_db_major_version = "6.0" | ||
| provider_instance_size_name = "M10" | ||
| auto_scaling_compute_enabled = false | ||
| cloud_backup = true | ||
| auto_scaling_disk_gb_enabled = true | ||
| disk_size_gb = 12 | ||
| provider_volume_type = "STANDARD" | ||
| retain_backups_enabled = true | ||
| advanced_configuration { | ||
| oplog_min_retention_hours = 8 | ||
| } | ||
| replication_specs { | ||
| num_shards = 1 | ||
| regions_config { | ||
| region_name = "US_EAST_1" | ||
| electable_nodes = 3 | ||
| priority = 7 | ||
| read_only_nodes = 0 | ||
| } | ||
| } | ||
| } | ||
| resource "mongodbatlas_cloud_backup_schedule" "test" { | ||
| cluster_name = mongodbatlas_cluster.test.name | ||
| project_id = mongodbatlas_project.test.id | ||
| reference_hour_of_day = 3 | ||
| reference_minute_of_hour = 45 | ||
| restore_window_days = 2 | ||
| copy_settings { | ||
| cloud_provider = "AWS" | ||
| frequencies = ["DAILY"] | ||
| region_name = "US_WEST_1" | ||
| replication_spec_id = one(mongodbatlas_cluster.test.replication_specs).id | ||
| should_copy_oplogs = false | ||
| } | ||
| } | ||
| ` | ||
| } | ||
| func TestAccGenericBackupRSBackupCompliancePolicy_withoutOptionals(t *testing.T) { | ||
| var ( | ||
| orgID = os.Getenv("MONGODB_ATLAS_ORG_ID") | ||
|
|
||