-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NODE-6268): update dev dependencies and add dependabot config #4196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
changed the title
update batch 1
chore: update dev dependencies and add dependabot config
Aug 16, 2024
baileympearson
changed the title
chore: update dev dependencies and add dependabot config
chore(NODE-6268): update dev dependencies and add dependabot config
Aug 16, 2024
baileympearson
commented
Aug 16, 2024
baileympearson
commented
Aug 16, 2024
baileympearson
force-pushed
the
deps
branch
4 times, most recently
from
August 20, 2024 22:17
989b1cd
to
3e1f0b4
Compare
baileympearson
commented
Aug 21, 2024
baileympearson
commented
Aug 21, 2024
baileympearson
commented
Aug 21, 2024
W-A-James
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Aug 22, 2024
W-A-James
reviewed
Aug 22, 2024
Co-authored-by: Warren James <[email protected]>
W-A-James
approved these changes
Aug 22, 2024
W-A-James
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Aug 22, 2024
nbbeeken
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the no-then removals seem to have left empty lines that I would've expected prettier to clean up, fine to leave as is but mentioning if you didn't notice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This is a pretty "large" PR - large in terms of files changed, not large in terms of actual substantial changes. This PR
I've tried to comment on any substantial changes made as a result of the eslint upgrade (spoiler: there aren't many).
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript