feat(NODE-6231): Add CSOT behaviour for retryable reads and writes #4186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
commented
Jul 29, 2024
Comment on lines
+288
to
+289
| timeoutContext.serverSelectionTimeout?.clear(); | ||
| timeoutContext.connectionCheckoutTimeout?.clear(); |
There was a problem hiding this comment.
clear timeouts to ensure correct setting of the serverSelectionTimeoutMS value
W-A-James
commented
Jul 29, 2024
| @@ -39,6 +39,7 @@ export class Timeout extends Promise<never> { | |||
| public ended: number | null = null; | |||
| public duration: number; | |||
| public timedOut = false; | |||
| public cleared = false; | |||
There was a problem hiding this comment.
Add cleared flag that gets set on Timeout.clear so that the TimeoutContext can know if it needs to reconstruct a Timeout for retrying operations
W-A-James
commented
Jul 29, 2024
Comment on lines
+24
to
+25
| 'timeoutMS applies to whole operation, not individual attempts - bulkWrite on collection', | ||
| 'timeoutMS applies to whole operation, not individual attempts - insertMany on collection' |
There was a problem hiding this comment.
Skipped for now. We seem to be throwing the TimeoutError at the correct place, but it's getting wrapped by the BulkWriteError
durran
requested changes
Jul 31, 2024
durran
added
the
Primary Review
durran
approved these changes
Jul 31, 2024
durran
added
Team Review
nbbeeken
pushed a commit
that referenced
this pull request
Aug 13, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Aug 20, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Aug 21, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Sep 12, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Sep 25, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Sep 27, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 1, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 1, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 10, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Oct 14, 2024
baileympearson
pushed a commit
that referenced
this pull request
Oct 21, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Nov 1, 2024
nbbeeken
pushed a commit
that referenced
this pull request
Nov 5, 2024
dariakp
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Timeoutto haveclearedflagCSOTTimeoutContextto correctly setserverSelectionTimeoutMSwhen retrying commandsIs there new documentation needed for these changes?
No - punting to CSOT release
What is the motivation for this change?
NODE-6231
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript