Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(NODE-6052): support assertions on topologyDescriptionChanged in expectEvents #4089

Merged
merged 16 commits into from
Apr 25, 2024
Merged

test(NODE-6052): support assertions on topologyDescriptionChanged in expectEvents #4089

merged 16 commits into from
Apr 25, 2024

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Apr 18, 2024 •
edited
Loading

Description

What is changing?

  • Pull in spec tests from DRIVERS-2875
  • Fix subtle bug in unified test runner where sdam event matching was exiting prematurely
  • Skip tests that are failing due to aforementioned runner bug changes. To be addressed in NODE-6045
Is there new documentation needed for these changes?

No

What is the motivation for this change?

NODE-6052

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James changed the title add spec tests test(NODE-6052): add spec tests Apr 19, 2024
@W-A-James W-A-James marked this pull request as ready for review April 19, 2024 20:21
@W-A-James W-A-James changed the title test(NODE-6052): add spec tests test(NODE-6052): support assertions on topologyDescriptionChanged in expectEvents Apr 19, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB self-assigned this Apr 19, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 19, 2024
@W-A-James W-A-James mentioned this pull request Apr 19, 2024
Open
5 tasks
aditi-khare-mongoDB
aditi-khare-mongoDB previously approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just waiting for CI to finish before I move to team review

@aditi-khare-mongoDB aditi-khare-mongoDB added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Apr 22, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB merged commit ca2bfb0 into main Apr 25, 2024
19 of 26 checks passed
@aditi-khare-mongoDB aditi-khare-mongoDB deleted the NODE-6052 branch April 25, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditi-khare-mongoDB aditi-khare-mongoDB aditi-khare-mongoDB approved these changes

@baileympearson baileympearson baileympearson approved these changes

Assignees

@aditi-khare-mongoDB aditi-khare-mongoDB

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@W-A-James @baileympearson @aditi-khare-mongoDB