Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4719): Add SDAM Logging Spec #3940

Merged
merged 23 commits into from
Dec 14, 2023
Merged

feat(NODE-4719): Add SDAM Logging Spec #3940

merged 23 commits into from
Dec 14, 2023

Conversation

aditi-khare-mongoDB
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB commented Dec 4, 2023 •
edited
Loading

Description

Added support for logging on SDAM Events, and SDAM spec tests.

What is changing?

All SDAM Events (except serverDescriptionChangedEvent) have a corresponding log. Using the emitAndLog function, we can output their information properly when logging is turned on.

Is there new documentation needed for these changes?

Not until logging is released (NODE-5672)

What is the motivation for this change?

To implement standardized logging for SDAM.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@aditi-khare-mongoDB aditi-khare-mongoDB marked this pull request as ready for review December 6, 2023 22:39
@nbbeeken nbbeeken self-assigned this Dec 7, 2023
@nbbeeken nbbeeken changed the title feat(Node 4719): Add SDAM Logging Spec feat(NODE-4719): Add SDAM Logging Spec Dec 7, 2023
nbbeeken
nbbeeken requested changes Dec 7, 2023
View reviewed changes
src/sdam/monitor.ts Outdated Show resolved Hide resolved
src/sdam/monitor.ts Outdated Show resolved Hide resolved
src/sdam/events.ts Outdated Show resolved Hide resolved
src/sdam/events.ts Outdated Show resolved Hide resolved
src/sdam/monitor.ts Outdated Show resolved Hide resolved
src/mongo_logger.ts Outdated Show resolved Hide resolved
src/mongo_logger.ts Outdated Show resolved Hide resolved
src/mongo_types.ts Show resolved Hide resolved
test/tools/unified-spec-runner/match.ts Show resolved Hide resolved
test/tools/unified-spec-runner/match.ts Show resolved Hide resolved
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 7, 2023
nbbeeken
nbbeeken requested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to merge in main to remove the conflicts, Monitor has been changed. And we have the action item from slack to figure out if we can add topologyId to our heartbeat events.

test/spec/server-discovery-and-monitoring/unified/logging-replicaset.json Outdated Show resolved Hide resolved
test/unit/sdam/monitor.test.ts Outdated Show resolved Hide resolved
src/mongo_types.ts Outdated Show resolved Hide resolved
nbbeeken
nbbeeken requested changes Dec 11, 2023
View reviewed changes
src/mongo_types.ts Outdated Show resolved Hide resolved
src/sdam/events.ts Outdated Show resolved Hide resolved
src/sdam/monitor.ts Outdated Show resolved Hide resolved
nbbeeken
nbbeeken reviewed Dec 11, 2023
View reviewed changes
src/mongo_logger.ts Outdated Show resolved Hide resolved
@nbbeeken nbbeeken requested a review from W-A-James December 11, 2023 21:06
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Dec 11, 2023
W-A-James
W-A-James requested changes Dec 12, 2023
View reviewed changes
src/mongo_types.ts Show resolved Hide resolved
test/tools/unified-spec-runner/match.ts Show resolved Hide resolved
nbbeeken
nbbeeken requested changes Dec 12, 2023
View reviewed changes
src/mongo_types.ts Show resolved Hide resolved
@nbbeeken nbbeeken merged commit a3c0298 into main Dec 14, 2023
26 checks passed
@nbbeeken nbbeeken deleted the NODE-4719/SDAM-logging branch December 14, 2023 15:29
@github-actions github-actions bot mentioned this pull request Dec 14, 2023
Merged
aditi-khare-mongoDB added a commit that referenced this pull request Dec 21, 2023
@aditi-khare-mongoDB
feat(NODE-4719): add SDAM Logging Spec (#3940)
0e8279f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W-A-James W-A-James W-A-James approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aditi-khare-mongoDB @nbbeeken @W-A-James