Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-2883): Aggregate Operation should not require parent parameter #2918

Merged
merged 6 commits into from
Jul 28, 2021
Merged

fix(NODE-2883): Aggregate Operation should not require parent parameter #2918

merged 6 commits into from
Jul 28, 2021

Commits on Jul 26, 2021

  1. fix: remove parent parameter from AggregateOperation and parent refer… 

    …ence from AggregationCursor
    @W-A-James
    W-A-James committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    dda834d View commit details
    Browse the repository at this point in the history

  2. refactor: Change AggregateOperation construtor parameter ordering

    @W-A-James
    W-A-James committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    5b4bc3f View commit details
    Browse the repository at this point in the history

  3. fix: change coalesce nullish to boolean or

    @W-A-James
    W-A-James committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    895e447 View commit details
    Browse the repository at this point in the history

  4. style: remove commented-out code

    @W-A-James
    W-A-James committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    f3d21de View commit details
    Browse the repository at this point in the history

  5. style: make check for undefined and empty string more verbose

    @W-A-James
    W-A-James committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    d54fff4 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. refactor: Restore nullish check and add comment for clarity

    @W-A-James
    W-A-James committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    e59f480 View commit details
    Browse the repository at this point in the history