Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3290): versioned api validation and tests #2869

Merged
merged 6 commits into from
Jul 14, 2021
Merged

fix(NODE-3290): versioned api validation and tests #2869

merged 6 commits into from
Jul 14, 2021

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Jun 30, 2021 •
edited
Loading

Backport of the versioned API updates made in #2809, also pulls in updates to test/tools/cluster_setup.sh from 4.0.

NODE-3290

@emadum emadum force-pushed the NODE-3290/3.7/backport-versioned-api-validation branch from 5eb64ce to 7b459d9 Compare June 30, 2021 19:24
@emadum emadum force-pushed the NODE-3290/3.7/backport-versioned-api-validation branch from 7b459d9 to b2e3b3a Compare June 30, 2021 19:38
@emadum emadum marked this pull request as ready for review June 30, 2021 19:55
@emadum emadum requested a review from nbbeeken June 30, 2021 20:40
@emadum emadum added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 1, 2021
nbbeeken
nbbeeken requested changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small Qs
Thanks for sync-ing the setup script!

lib/core/index.js Outdated Show resolved Hide resolved
lib/mongo_client.js Outdated Show resolved Hide resolved
@nbbeeken
Copy link
Contributor

nbbeeken commented Jul 6, 2021

@emadum This looks ready to go in the sense that it has the validation and tests but the diff looks like its bringing more in than intended, I think 3.7 needs a fastforward before merging?

@emadum emadum requested a review from nbbeeken July 14, 2021 18:27
nbbeeken
nbbeeken approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken requested review from dariakp and durran July 14, 2021 19:14
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 14, 2021
dariakp
dariakp approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@nbbeeken nbbeeken changed the title fix(NODE-3290): backport versioned api validation and tests fix(NODE-3290): versioned api validation and tests Jul 14, 2021
@nbbeeken nbbeeken merged commit 238a4b0 into 3.7 Jul 14, 2021
@nbbeeken nbbeeken deleted the NODE-3290/3.7/backport-versioned-api-validation branch July 14, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

@durran durran Awaiting requested review from durran

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emadum @nbbeeken @dariakp