Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect readPreference and writeConcern from connection string #2711

Merged
merged 2 commits into from
Jan 25, 2021
Merged

fix: respect readPreference and writeConcern from connection string #2711

merged 2 commits into from
Jan 25, 2021

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Jan 21, 2021

Description

NODE-2965

What changed?

Are there any files to ignore?

@emadum emadum force-pushed the NODE-2965/3.6/respect-rw-concern-from-uri branch from 15ff2e0 to 4dbd767 Compare January 21, 2021 18:07
@emadum emadum marked this pull request as ready for review January 21, 2021 21:12
@emadum emadum requested review from nbbeeken and durran January 21, 2021 21:12
durran
durran approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emadum emadum merged commit b657c8c into 3.6 Jan 25, 2021
@emadum emadum deleted the NODE-2965/3.6/respect-rw-concern-from-uri branch January 25, 2021 14:11
@emadum emadum mentioned this pull request Jan 25, 2021
Merged
This was referenced Mar 9, 2021
Closed
Closed
Merged
Merged
Open
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@durran durran durran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emadum @durran @nbbeeken