Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply bson options for bulk operations #2601

Merged
merged 3 commits into from
Nov 5, 2020
Merged

fix: apply bson options for bulk operations #2601

merged 3 commits into from
Nov 5, 2020

Conversation

HanaPearlman
Copy link
Contributor

@HanaPearlman HanaPearlman commented Oct 27, 2020 •
edited
Loading

This change extends the work from #2589 to bulk operations. The changes involved for BulkOperationBase parallel those for OperationBase: a new bsonOptions field was added (in s, so it's at the same level as options) with values inherited from the collection parent, it is exposed with a bsonOptions getter, and it is included in the options before any executeOperation is called.

NODE-1561

@mbroadst
Copy link
Member

mbroadst commented Nov 2, 2020

@HanaPearlman is this ready for review?

@HanaPearlman HanaPearlman marked this pull request as ready for review November 2, 2020 13:31
nbbeeken
nbbeeken reviewed Nov 2, 2020
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two little style nits, and a suggested improvement, looking good to me 👍

src/collection.ts Outdated Show resolved Hide resolved
src/collection.ts Outdated Show resolved Hide resolved
test/functional/bulk.test.js Outdated Show resolved Hide resolved
@HanaPearlman HanaPearlman requested a review from nbbeeken November 2, 2020 15:51
emadum
emadum approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@HanaPearlman HanaPearlman merged commit e01cafd into mongodb:master Nov 5, 2020
@HanaPearlman HanaPearlman deleted the NODE-1561/master/bulk-unify-ignoreUndefined branch November 5, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@mbroadst mbroadst mbroadst approved these changes

@emadum emadum emadum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HanaPearlman @mbroadst @emadum @nbbeeken