test: ensure connection with sharded topology #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroadst
approved these changes
Oct 14, 2020
emadum
approved these changes
Oct 16, 2020
| it('Should use sharded topology', { | ||
| metadata: { requires: { topology: 'sharded' } }, | ||
| test: function () { | ||
| const client = this.configuration.newClient({}); |
There was a problem hiding this comment.
Why was this necessary? If you're not passing custom options into this.configuration.newClient, this should be the same as test: withClient((client, done) => {...})
There was a problem hiding this comment.
Updated! This is a port, and I believe I needed to pass in useUnifiedTopology in 3.6 and that's why I did it this way, but then possibly removed the option here because of the warning?
There was a problem hiding this comment.
Damn, i missed this push locally. I think it's OK to leave in, hope we revamp and check through withClient calls later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NODE-2827
bringing in test from #2557