test(change-streams): reenable test validating ReadPreference

NODE-1187
mongodb · Dec 4, 2017 · aa5e705 · aa5e705
1 parent 9e06d5f
commit aa5e705
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/change_stream.js b/lib/change_stream.js
@@ -49,7 +49,7 @@ var ChangeStream = function(collection, pipeline, options) {
   self.serverConfig = collection.s.db.serverConfig;
 
   // Determine correct read preference
-  // self.options.readPreference = self.options.readPreference || collection.s.readPreference;
+  self.options.readPreference = self.options.readPreference || collection.s.readPreference;
 
   // Create contained Change Stream cursor
   self.cursor = createChangeStreamCursor(self);

diff --git a/test/functional/change_stream_tests.js b/test/functional/change_stream_tests.js
@@ -1201,7 +1201,7 @@ describe('Change Streams', function() {
     }
   });
 
-  it.skip('Should create Change Streams with correct read preferences', {
+  it('Should create Change Streams with correct read preferences', {
     metadata: { requires: { topology: 'replicaset', mongodb: '>=3.5.10' } },
 
     // The actual test we wish to run
@@ -1216,6 +1216,7 @@ describe('Change Streams', function() {
         var database = client.db('integration_tests', {
           readPreference: ReadPreference.PRIMARY_PREFERRED
         });
+
         var changeStream0 = database.collection('docs0').watch(pipeline);
         assert.deepEqual(
           changeStream0.cursor.readPreference.preference,
@@ -1226,6 +1227,7 @@ describe('Change Streams', function() {
         var collection = database.collection('docs1', {
           readPreference: ReadPreference.SECONDARY_PREFERRED
         });
+
         var changeStream1 = collection.watch(pipeline);
         assert.deepEqual(
           changeStream1.cursor.readPreference.preference,
@@ -1430,10 +1432,10 @@ describe('Change Streams', function() {
 
             var parsedFileContents = JSON.parse(fileContents);
             assert.equal(parsedFileContents.fullDocument.a, 1);
-            
+
 
             watcher.close();
-            
+
             thisChangeStream.close(function(err) {
               assert.ifError(err);