Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CLOUDP-215956 - Convert our bug report issue on GitHub to forms #861

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Dec 19, 2023

Proposed changes

Jira ticket: CLOUDP-215956

Same PR for TF mongodb/terraform-provider-mongodbatlas#1767

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

@andreaangiolillo andreaangiolillo marked this pull request as ready for review December 19, 2023 18:27
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner December 19, 2023 18:27
lantoli
lantoli previously approved these changes Dec 19, 2023
README.md Outdated Show resolved Hide resolved
@andreaangiolillo andreaangiolillo added this pull request to the merge queue Dec 20, 2023
Merged via the queue into master with commit 3a8efee Dec 20, 2023
26 checks passed
@andreaangiolillo andreaangiolillo deleted the CLOUDP-215192 branch December 20, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants