Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-166250: Do not print credentials for AtlasProject resources #907

Merged
merged 1 commit into from
Mar 23, 2023
Merged

CLOUDP-166250: Do not print credentials for AtlasProject resources #907

merged 1 commit into from
Mar 23, 2023

Conversation

igor-karpukhin
Copy link
Collaborator

All Submissions:

Do not print credentials for AtlasProject resources

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@github-actions
Copy link
Contributor

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/b6cf88364843728a16e1965f0d14e1bb431591b1

helderjs
helderjs approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@helderjs helderjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

fabritsius
fabritsius approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@fabritsius fabritsius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍
I think it's ok to show all of the ID fields but not against this being merged as is:)

@igor-karpukhin igor-karpukhin merged commit 1bcbdbb into main Mar 23, 2023
@igor-karpukhin igor-karpukhin deleted the CLOUDP-166250/no-secrets-in-logs branch March 23, 2023 13:41
fabritsius pushed a commit that referenced this pull request Mar 24, 2023
@igor-karpukhin @fabritsius
Do not print credentials for AtlasProject resources (#907)
253036c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabritsius fabritsius fabritsius approved these changes

@helderjs helderjs helderjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igor-karpukhin @helderjs @fabritsius