Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-166249: Fixed missing export field #897

Merged
merged 1 commit into from
Mar 22, 2023
Merged

CLOUDP-166249: Fixed missing export field #897

merged 1 commit into from
Mar 22, 2023

Conversation

igor-karpukhin
Copy link
Collaborator

@igor-karpukhin igor-karpukhin commented Mar 14, 2023 •
edited
Loading

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2023 •
edited
Loading

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/6eb95d81e57dd027f73d1cf8c34ea702c80e2d7d

@igor-karpukhin igor-karpukhin force-pushed the CLOUDP-166249/missing-export-field branch from ed41d6a to 5263c8a Compare March 14, 2023 11:30
@igor-karpukhin igor-karpukhin marked this pull request as ready for review March 14, 2023 17:28
fabritsius
fabritsius approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@fabritsius fabritsius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great 👍

helderjs
helderjs approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@helderjs helderjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@igor-karpukhin igor-karpukhin force-pushed the CLOUDP-166249/missing-export-field branch 3 times, most recently from 7fc7fbe to 9bbac6d Compare March 18, 2023 20:14
helderjs
helderjs requested changes Mar 20, 2023
View reviewed changes
test/int/deployment_test.go Outdated Show resolved Hide resolved
@igor-karpukhin igor-karpukhin force-pushed the CLOUDP-166249/missing-export-field branch from 9bbac6d to 6eb95d8 Compare March 20, 2023 08:47
@igor-karpukhin igor-karpukhin requested a review from helderjs March 20, 2023 10:58
@igor-karpukhin
Copy link
Collaborator Author

Encryption at REST fails because of incorrect AWS credentials on all PRs, not related to these PR changes.

@igor-karpukhin igor-karpukhin merged commit c81acd2 into main Mar 22, 2023
@igor-karpukhin igor-karpukhin deleted the CLOUDP-166249/missing-export-field branch March 22, 2023 12:09
fabritsius pushed a commit that referenced this pull request Mar 24, 2023
@igor-karpukhin @fabritsius
Fixed missing export field (#897)
f961bc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabritsius fabritsius fabritsius approved these changes

@helderjs helderjs helderjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igor-karpukhin @helderjs @fabritsius