CLOUDP-280012: Add http dry run transport for Atlas #2026
+371
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-urbaniak
temporarily deployed
to
openshift-test
GitHub Actions
Inactive
helderjs
approved these changes
Jan 8, 2025
josvazg
reviewed
Jan 8, 2025
josvazg
approved these changes
Jan 8, 2025
igor-karpukhin
approved these changes
Jan 9, 2025
roothorp
approved these changes
Jan 9, 2025
| @@ -121,48 +127,58 @@ func (p *ProductionProvider) Client(ctx context.Context, secretRef *client.Objec | |||
| return c, secretData.OrgID, err | |||
| } | |||
|
|
|||
| func (p *ProductionProvider) SdkClient(ctx context.Context, secretRef *client.ObjectKey, log *zap.SugaredLogger) (*admin.APIClient, string, error) { | |||
| secretData, err := getSecrets(ctx, p.k8sClient, secretRef, &p.globalSecretRef) | |||
| func (p *ProductionProvider) SdkClient(ctx context.Context, secretRef *client.ObjectKey, log *zap.SugaredLogger) (*adminv20231115008.APIClient, string, error) { | |||
There was a problem hiding this comment.
nit: is it worth mentioning why this is a special case? or maybe even marking this method as deprecated to encourage always using SdkClientSet in future?
| } | ||
| var transport http.RoundTripper = digest.NewTransport(secretData.PublicKey, secretData.PrivateKey) | ||
| transport = p.newDryRunTransport(transport) | ||
| transport = httputil.NewLoggingTransport(log, false, transport) |
There was a problem hiding this comment.
Does this mean we will be logging all of the SDK Atlas API calls? This will be lovely for debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dry run transport towards Atlas calls. Note that this contribution is a no-op for now. The operator starts in non-dry-run mode.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).