Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-273419: Don't delete teams when not assigned to a project #1829

Merged
merged 2 commits into from
Sep 23, 2024
Merged

CLOUDP-273419: Don't delete teams when not assigned to a project #1829

merged 2 commits into from
Sep 23, 2024

Conversation

helderjs
Copy link
Collaborator

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes-template.md if your changes should be included in the release notes for the next release.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/98ed792964d3323562de8f852dd6a9e627854d01

josvazg
josvazg approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

roothorp
roothorp reviewed Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@roothorp roothorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question. Love all the testing!

@helderjs helderjs merged commit 9960404 into main Sep 23, 2024
56 checks passed
@helderjs helderjs deleted the CLOUDP-273419-dont-delete-teams branch September 23, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roothorp roothorp roothorp approved these changes

@josvazg josvazg josvazg approved these changes

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@igor-karpukhin igor-karpukhin Awaiting requested review from igor-karpukhin

@cveticm cveticm Awaiting requested review from cveticm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helderjs @josvazg @roothorp