Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-211174: Backup Compliance Policies #1623

Merged
merged 67 commits into from
Jun 26, 2024
Merged

CLOUDP-211174: Backup Compliance Policies #1623

merged 67 commits into from
Jun 26, 2024

Conversation

roothorp
Copy link
Collaborator

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes-template.md if your changes should be included in the release notes for the next release.

josvazg
josvazg reviewed May 31, 2024
View reviewed changes
cmd/manager/main.go Outdated Show resolved Hide resolved
josvazg
josvazg reviewed May 31, 2024
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, some comments and many nits

pkg/api/v1/atlascustomresource.go Show resolved Hide resolved
pkg/controller/atlasbackupcompliancepolicy/atlasbackupcompliancepolicy_controller.go Show resolved Hide resolved
pkg/controller/atlasbackupcompliancepolicy/atlasbackupcompliancepolicy_controller.go Outdated Show resolved Hide resolved
pkg/controller/atlasproject/backupcompliancepolicy.go Outdated Show resolved Hide resolved
pkg/controller/atlasproject/backupcompliancepolicy.go Show resolved Hide resolved
pkg/controller/atlasproject/backupcompliancepolicy.go Outdated Show resolved Hide resolved
pkg/controller/atlasproject/backupcompliancepolicy.go Outdated Show resolved Hide resolved
@s-urbaniak s-urbaniak force-pushed the CLOUDP-211174-backup-compliance branch from 32f5ccd to 00a6450 Compare June 3, 2024 11:03
@roothorp roothorp force-pushed the CLOUDP-211174-backup-compliance branch 2 times, most recently from 0341cc2 to 6a1a8a4 Compare June 6, 2024 13:51
@roothorp roothorp force-pushed the CLOUDP-211174-backup-compliance branch from 161412e to aabff86 Compare June 6, 2024 14:54
josvazg
josvazg reviewed Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just some nitpicks and a question on the e2e test.

test/e2e/backup_compliance_test.go Show resolved Hide resolved
@roothorp roothorp force-pushed the CLOUDP-211174-backup-compliance branch from 7317561 to d4528ba Compare June 17, 2024 14:11
@roothorp roothorp force-pushed the CLOUDP-211174-backup-compliance branch from 617cfc8 to c617c88 Compare June 26, 2024 10:29
@roothorp roothorp merged commit e4573a4 into main Jun 26, 2024
57 checks passed
@roothorp roothorp deleted the CLOUDP-211174-backup-compliance branch September 26, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josvazg josvazg josvazg approved these changes

@s-urbaniak s-urbaniak s-urbaniak approved these changes

@helderjs helderjs helderjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roothorp @helderjs @s-urbaniak @josvazg